netdev - Re: [PATCH net-next] bpf: Remove duplicate tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+WfuZXv6RBaOcriVG2ieTqAD2jQqXcf7wS4__q9EoaBA@mail.gmail.com>
Date:   Fri, 9 Jun 2017 14:12:45 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Chenbo Feng <chenbofeng.kernel@...il.com>
Cc:     netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Lorenzo Colitti <lorenzo@...gle.com>,
        Chenbo Feng <fengc@...gle.com>
Subject: Re: [PATCH net-next] bpf: Remove duplicate tcp_filter hook in ipv6

On Fri, Jun 9, 2017 at 12:17 PM, Chenbo Feng
<chenbofeng.kernel@...il.com> wrote:
> From: Chenbo Feng <fengc@...gle.com>
>
> There are two tcp_filter hooks in tcp_ipv6 ingress path currently.
> One is at tcp_v6_rcv and another is in tcp_v6_do_rcv. It seems the
> tcp_filter() call inside tcp_v6_do_rcv is redundent and some packet
> will be filtered twice in this situation. This will cause trouble
> when using eBPF filters to account traffic data.
>
> Signed-off-by: Chenbo Feng <fengc@...gle.com>
> Acked-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  net/ipv6/tcp_ipv6.c | 3 ---
>  1 file changed, 3 deletions(-)

Yes, this is the patch I agreed on ;)

Thanks