netdev - Re: [PATCH net-next] bpf: Remove duplicate tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170610.160819.564348879790810911.davem@davemloft.net>
Date:   Sat, 10 Jun 2017 16:08:19 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     chenbofeng.kernel@...il.com
Cc:     netdev@...r.kernel.org, lorenzo@...gle.com, edumazet@...gle.com,
        fengc@...gle.com
Subject: Re: [PATCH net-next] bpf: Remove duplicate tcp_filter hook in ipv6

From: Chenbo Feng <chenbofeng.kernel@...il.com>
Date: Fri,  9 Jun 2017 12:17:37 -0700

> From: Chenbo Feng <fengc@...gle.com>
> 
> There are two tcp_filter hooks in tcp_ipv6 ingress path currently.
> One is at tcp_v6_rcv and another is in tcp_v6_do_rcv. It seems the
> tcp_filter() call inside tcp_v6_do_rcv is redundent and some packet
> will be filtered twice in this situation. This will cause trouble
> when using eBPF filters to account traffic data.
> 
> Signed-off-by: Chenbo Feng <fengc@...gle.com>
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied, thank you.