netdev - [net:master 31/33] net//core/dev.c:8252:2: warning: 'remsd' is used uninitialized in this function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <201706100809.VQ13j4Fw%fengguang.wu@intel.com>
Date:   Sat, 10 Jun 2017 08:59:26 +0800
From:   kbuild test robot <fengguang.wu@...el.com>
To:     "ashwanth@...eaurora.org" <ashwanth@...eaurora.org>
Cc:     kbuild-all@...org, netdev@...r.kernel.org
Subject: [net:master 31/33] net//core/dev.c:8252:2: warning: 'remsd' is used
 uninitialized in this function

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
head:   f6d4c7133257bb2d6f66723d11b19f1c49cdf2f7
commit: 773fc8f6e8d63ec9d840588e161cbb73a01cfc45 [31/33] net: rps: send out pending IPI's on CPU hotplug
config: blackfin-allyesconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 773fc8f6e8d63ec9d840588e161cbb73a01cfc45
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All warnings (new ones prefixed by >>):

   net//core/dev.c: In function 'dev_cpu_dead':
>> net//core/dev.c:8252:2: warning: 'remsd' is used uninitialized in this function [-Wuninitialized]
     net_rps_send_ipi(remsd);
     ^~~~~~~~~~~~~~~~~~~~~~~

vim +/remsd +8252 net//core/dev.c

  8236	
  8237			list_del_init(&napi->poll_list);
  8238			if (napi->poll == process_backlog)
  8239				napi->state = 0;
  8240			else
  8241				____napi_schedule(sd, napi);
  8242		}
  8243	
  8244		raise_softirq_irqoff(NET_TX_SOFTIRQ);
  8245		local_irq_enable();
  8246	
  8247	#ifdef CONFIG_RPS
  8248		remsd = oldsd->rps_ipi_list;
  8249		oldsd->rps_ipi_list = NULL;
  8250	#endif
  8251		/* send out pending IPI's on offline CPU */
> 8252		net_rps_send_ipi(remsd);
  8253	
  8254		/* Process offline CPU's input_pkt_queue */
  8255		while ((skb = __skb_dequeue(&oldsd->process_queue))) {
  8256			netif_rx_ni(skb);
  8257			input_queue_head_incr(oldsd);
  8258		}
  8259		while ((skb = skb_dequeue(&oldsd->input_pkt_queue))) {
  8260			netif_rx_ni(skb);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (44973 bytes)