netdev - Re: [PATCH net-next] net: fec: Clear and enable MIB counters on imx51

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Jun 2017 21:01:26 -0400
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     David Miller <davem@...emloft.net>
Cc:     andrew@...n.ch, netdev <netdev@...r.kernel.org>,
        nikita.yoush@...entembedded.com, fabio.estevam@....com,
        cphealy@...il.com,
        "linux-next@...r.kernel.org" <linux-next@...r.kernel.org>
Subject: Re: [PATCH net-next] net: fec: Clear and enable MIB counters on imx51

On Wed, Jun 7, 2017 at 10:07 AM, David Miller <davem@...emloft.net> wrote:
> From: Andrew Lunn <andrew@...n.ch>
> Date: Wed,  7 Jun 2017 03:57:09 +0200
>
>> Both the IMX51 and IMX53 datasheet indicates that the MIB counters
>> should be cleared during setup. Otherwise random numbers are returned
>> via ethtool -S.  Add a quirk and a function to do this.

Seems to break one of the automated linux-next builds:

http://kisskb.ellerman.id.au/kisskb/buildresult/13057702/

A mindless automated bisect reports:

2b30842b23b9e6796c7bd5f0916fd2ebf6b7d633 is the first bad commit
commit 2b30842b23b9e6796c7bd5f0916fd2ebf6b7d633
Author: Andrew Lunn <andrew@...n.ch>
Date:   Wed Jun 7 03:57:09 2017 +0200

    net: fec: Clear and enable MIB counters on imx51

Paul.
--

>>
>> Tested on an IMX51.
>>
>> Signed-off-by: Andrew Lunn <andrew@...n.ch>
>
> Applied, thanks.