netdev - Re: [PATCH net-next] net: fec: Clear and enable MIB counters on imx51

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5A1hh=6npHGkK8Y+0F_ta+Kr-5OxRdqyqmma_xis84WqA@mail.gmail.com>
Date:   Fri, 9 Jun 2017 22:12:59 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     David Miller <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>,
        netdev <netdev@...r.kernel.org>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Fabio Estevam <fabio.estevam@....com>,
        Chris Healy <cphealy@...il.com>,
        "linux-next@...r.kernel.org" <linux-next@...r.kernel.org>
Subject: Re: [PATCH net-next] net: fec: Clear and enable MIB counters on imx51

Hi Paul,

On Fri, Jun 9, 2017 at 10:01 PM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> Seems to break one of the automated linux-next builds:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/13057702/
>
> A mindless automated bisect reports:
>
> 2b30842b23b9e6796c7bd5f0916fd2ebf6b7d633 is the first bad commit
> commit 2b30842b23b9e6796c7bd5f0916fd2ebf6b7d633
> Author: Andrew Lunn <andrew@...n.ch>
> Date:   Wed Jun 7 03:57:09 2017 +0200
>
>     net: fec: Clear and enable MIB counters on imx51

This should fix it:

--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2379,6 +2379,10 @@ static void fec_enet_clear_ethtool_stats(struct
net_device *dev)
 static inline void fec_enet_update_ethtool_stats(struct net_device *dev)
 {
 }
+
+static inline void fec_enet_clear_ethtool_stats(struct net_device *dev)
+{
+}
 #endif /* !defined(CONFIG_M5272) */

 /* ITR clock source is enet system clock (clk_ahb).

Will test it and submit a formal patch in case it works.

Thanks