netdev - Re: [net-next] macvlan: propagate the mac address change status for lowerdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170613203408.GA3112@yuvallap>
Date:   Tue, 13 Jun 2017 23:34:09 +0300
From:   Yuval Shaia <yuval.shaia@...cle.com>
To:     Zhang Shengju <zhangshengju@...s.chinamobile.com>
Cc:     davem@...emloft.net, fgao@...vckh6395k16k5.yundunddos.com,
        vyasevic@...hat.com, netdev@...r.kernel.org
Subject: Re: [net-next] macvlan: propagate the mac address change status for
 lowerdev

On Tue, Jun 13, 2017 at 10:45:11PM +0800, Zhang Shengju wrote:
> The macvlan dev should propagate the return value of mac address change for
> lower device in the passthru mode, instead of always return 0.
> 
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> ---
>  drivers/net/macvlan.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
> index 346ad2f..ade1213 100644
> --- a/drivers/net/macvlan.c
> +++ b/drivers/net/macvlan.c
> @@ -703,10 +703,8 @@ static int macvlan_set_mac_address(struct net_device *dev, void *p)
>  	if (!is_valid_ether_addr(addr->sa_data))
>  		return -EADDRNOTAVAIL;
>  
> -	if (vlan->mode == MACVLAN_MODE_PASSTHRU) {
> -		dev_set_mac_address(vlan->lowerdev, addr);
> -		return 0;
> -	}
> +	if (vlan->mode == MACVLAN_MODE_PASSTHRU)
> +		return dev_set_mac_address(vlan->lowerdev, addr);

Do you think the following functions needs this fix as well?
- alb_set_mac_address
- bond_alb_handle_active_change
- bond_enslave
- __bond_release_one
- macvlan_set_mac_address

Yuval

>  
>  	return macvlan_sync_address(dev, addr->sa_data);
>  }
> -- 
> 1.8.3.1
> 
> 
>