netdev - RE: [net-next] macvlan: propagate the mac address change status for lowerdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000801d2e522$9019e2b0$b04da810$@cmss.chinamobile.com>
Date:   Wed, 14 Jun 2017 23:26:14 +0800
From:   张胜举 <zhangshengju@...s.chinamobile.com>
To:     "'Yuval Shaia'" <yuval.shaia@...cle.com>
Cc:     <davem@...emloft.net>, <fgao@...vckh6395k16k5.yundunddos.com>,
        <vyasevic@...hat.com>, <netdev@...r.kernel.org>
Subject: RE: [net-next] macvlan: propagate the mac address change status for lowerdev

> -----Original Message-----
> From: Yuval Shaia [mailto:yuval.shaia@...cle.com]
> Sent: Wednesday, June 14, 2017 4:34 AM
> To: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Cc: davem@...emloft.net; fgao@...vckh6395k16k5.yundunddos.com;
> vyasevic@...hat.com; netdev@...r.kernel.org
> Subject: Re: [net-next] macvlan: propagate the mac address change status
> for lowerdev
> 
> On Tue, Jun 13, 2017 at 10:45:11PM +0800, Zhang Shengju wrote:
> > The macvlan dev should propagate the return value of mac address
> > change for lower device in the passthru mode, instead of always return
0.
> >
> > Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> > ---
> >  drivers/net/macvlan.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index
> > 346ad2f..ade1213 100644
> > --- a/drivers/net/macvlan.c
> > +++ b/drivers/net/macvlan.c
> > @@ -703,10 +703,8 @@ static int macvlan_set_mac_address(struct
> net_device *dev, void *p)
> >  	if (!is_valid_ether_addr(addr->sa_data))
> >  		return -EADDRNOTAVAIL;
> >
> > -	if (vlan->mode == MACVLAN_MODE_PASSTHRU) {
> > -		dev_set_mac_address(vlan->lowerdev, addr);
> > -		return 0;
> > -	}
> > +	if (vlan->mode == MACVLAN_MODE_PASSTHRU)
> > +		return dev_set_mac_address(vlan->lowerdev, addr);
> 
> Do you think the following functions needs this fix as well?
> - alb_set_mac_address
> - bond_alb_handle_active_change
> - bond_enslave
> - __bond_release_one
> - macvlan_set_mac_address
> 
> Yuval
Actually, this patch fixes macvlan part. 
The other part is not so easy to fix in my option, you can try to fix if
possible.

BRs,
ZSJ
> 
> >
> >  	return macvlan_sync_address(dev, addr->sa_data);  }
> > --
> > 1.8.3.1
> >
> >
> >