netdev - Re: [RFC PATCH net-next 05/15] bpf: Support for setting initial receive window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170613.171418.2256613910701215130.davem@davemloft.net>
Date:   Tue, 13 Jun 2017 17:14:18 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     brakmo@...com
Cc:     netdev@...r.kernel.org, kernel-team@...com, bmatheny@...com,
        ast@...com, daniel@...earbox.net, dsa@...ulusnetworks.com
Subject: Re: [RFC PATCH net-next 05/15] bpf: Support for setting initial
 receive window

From: Lawrence Brakmo <brakmo@...com>
Date: Tue, 13 Jun 2017 10:59:54 -0700

> diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
> index d0642df..a0032ea 100644
> --- a/net/ipv4/tcp_minisocks.c
> +++ b/net/ipv4/tcp_minisocks.c
> @@ -352,6 +352,7 @@ void tcp_openreq_init_rwin(struct request_sock *req,
>  	u32 window_clamp;
>  	__u8 rcv_wscale;
>  	int mss;
> +	u32 rcv_wnd;

Please order local variables from longest to shortest line.

 ...
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 503e478..972a985 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -3267,6 +3267,7 @@ static void tcp_connect_init(struct sock *sk)
>  	const struct dst_entry *dst = __sk_dst_get(sk);
>  	struct tcp_sock *tp = tcp_sk(sk);
>  	__u8 rcv_wscale;
> +	u32 rcv_wnd;

Likewise.