netdev - Re: [RFC PATCH net-next 06/15] bpf: Sample bpf program to set initial window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170613.171452.1515304283256474282.davem@davemloft.net>
Date:   Tue, 13 Jun 2017 17:14:52 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     brakmo@...com
Cc:     netdev@...r.kernel.org, kernel-team@...com, bmatheny@...com,
        ast@...com, daniel@...earbox.net, dsa@...ulusnetworks.com
Subject: Re: [RFC PATCH net-next 06/15] bpf: Sample bpf program to set
 initial window

From: Lawrence Brakmo <brakmo@...com>
Date: Tue, 13 Jun 2017 10:59:55 -0700

> +SEC("sockops")
> +int bpf_rwnd(struct __sk_buff *skb)
> +{
> +	struct bpf_socket_ops *skops = (struct bpf_socket_ops *) skb;
> +	char fmt1[] = "BPF command: %d\n";
> +	char fmt2[] = "  Returning %d\n";
> +	int op;
> +	int rv = -1;

Longest to shortest line for local variable declarations please.

> +
> +	// For testing purposes, only execute rest of BPF program
> +	// if neither port numberis 55601

Again, please use non-C++ comments.

Thank you.