netdev - Re: [PATCH iproute2] ip: mroute: Add table output to show command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49928c50-98a3-03e7-09e2-93c2b79644f7@cumulusnetworks.com>
Date:   Wed, 14 Jun 2017 18:44:36 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     David Ahern <dsahern@...il.com>,
        Donald Sharp <sharpd@...ulusnetworks.com>,
        netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH iproute2] ip: mroute: Add table output to show command

On 14/06/17 18:42, David Ahern wrote:
> On 6/14/17 6:08 AM, Donald Sharp wrote:
>> diff --git a/ip/ipmroute.c b/ip/ipmroute.c
>> index 4d2d758..70f4c4f 100644
>> --- a/ip/ipmroute.c
>> +++ b/ip/ipmroute.c
>> @@ -189,6 +189,11 @@ int print_mroute(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
>>  		fprintf(fp, ", Age %4i.%.2i", (int)tv.tv_sec,
>>  			(int)tv.tv_usec/10000);
>>  	}
>> +
>> +	if (table && (table != RT_TABLE_MAIN || show_details > 0) && !filter.tb)
>> +		fprintf(fp, " Table: %s",
> 
> I suggest lowercase 'table' to be consistent with ip route output.

This is consistent with the mroute show command, all of its fields start
with upper case.

> 
>> +			rtnl_rttable_n2a(table, b1, sizeof(b1)));
>> +
>>  	fprintf(fp, "\n");
>>  	fflush(fp);
>>  	return 0;
>> --