netdev - Re: [PATCH iproute2] ip: mroute: Add table output to show command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <493edb0e-d446-39a8-12a1-2ec7894f97f1@gmail.com>
Date:   Wed, 14 Jun 2017 09:47:45 -0600
From:   David Ahern <dsahern@...il.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        Donald Sharp <sharpd@...ulusnetworks.com>,
        netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH iproute2] ip: mroute: Add table output to show command

On 6/14/17 9:44 AM, Nikolay Aleksandrov wrote:
> On 14/06/17 18:42, David Ahern wrote:
>> On 6/14/17 6:08 AM, Donald Sharp wrote:
>>> diff --git a/ip/ipmroute.c b/ip/ipmroute.c
>>> index 4d2d758..70f4c4f 100644
>>> --- a/ip/ipmroute.c
>>> +++ b/ip/ipmroute.c
>>> @@ -189,6 +189,11 @@ int print_mroute(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
>>>  		fprintf(fp, ", Age %4i.%.2i", (int)tv.tv_sec,
>>>  			(int)tv.tv_usec/10000);
>>>  	}
>>> +
>>> +	if (table && (table != RT_TABLE_MAIN || show_details > 0) && !filter.tb)
>>> +		fprintf(fp, " Table: %s",
>> I suggest lowercase 'table' to be consistent with ip route output.
> This is consistent with the mroute show command, all of its fields start
> with upper case.
> 

ok.