netdev - Re: [PATCH iproute/master 2/3] iptunnel: add support for mpls/ip to sit tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eed46e61-80d0-4c7e-86c7-dc619b849ad8@gmail.com>
Date:   Wed, 14 Jun 2017 11:16:20 -0600
From:   David Ahern <dsahern@...il.com>
To:     Krister Johansen <kjlx@...pleofstupid.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, simon.horman@...ronome.com
Subject: Re: [PATCH iproute/master 2/3] iptunnel: add support for mpls/ip to
 sit tunnels

On 6/14/17 11:11 AM, Krister Johansen wrote:
> I did try to fix this up as part of bringing this patch up to date,
> since it was one of the concerns that David raised too.  I believe the
> problem that I ran into was that IPPROTO_MPLS wasn't defined in all
> versions of the headers where I tried to include them, and by bringing
> in in.h, I also managed to get a bunch of errors around re-definition of
> other symbols.
> 
> That said, I don't believe that 137 as the IPPROTO_MPLS value should
> change anytime soon.  It's defined in RFC 4023.
> 
> 	https://tools.ietf.org/html/rfc4023
> 
> However, if this is still seems problematic, I can take another shot at
> attempting to clean this up further.

IPPROTO_MPLS is defined in include/linux/in.h in iproute2.