netdev - Re: [PATCH] RDS: IB: NULL dereference on error in rds_ib_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <eecbb80f-9df3-e717-7af2-4407a3a40d3c@oracle.com>
Date:   Wed, 14 Jun 2017 10:18:25 -0700
From:   "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Avinash Repaka <avinash.repaka@...cle.com>,
        linux-rdma@...r.kernel.org, rds-devel@....oracle.com,
        kernel-janitors@...r.kernel.org,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] RDS: IB: NULL dereference on error in rds_ib_alloc_frmr()

On 6/14/17 3:39 AM, Dan Carpenter wrote:
> We accidentally return ERR_PTR(0) if ib_alloc_mr() fails.  The caller
> is expecting error pointers so it results in a NULL dereference.
>
> Fixes: 1659185fb4d0 ("RDS: IB: Support Fastreg MR (FRMR) memory registration mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
Thanks Dan for fix.

Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>

You haven't copied netdev. Can you please resend the patch
with my ack on netdev so that Dave can pick it up.