netdev - Re: [PATCH] skbuff: make skb_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1497475096.18751.76.camel@perches.com>
Date:   Wed, 14 Jun 2017 14:18:16 -0700
From:   Joe Perches <joe@...ches.com>
To:     Johannes Berg <johannes@...solutions.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] skbuff: make skb_put_zero() return void

On Wed, 2017-06-14 at 22:40 +0200, Johannes Berg wrote:
> On Wed, 2017-06-14 at 13:36 -0700, Joe Perches wrote:
> > 
> > Given you are adding a lot of these, it might be better
> > to add an exported function that duplicates most of
> > skb_put with a memset at the end.
> 
> Yeah, could be done. I'm not sure why you'd want to duplicate it rather
> than call it though? To make it about as fast?

Yeah, that and reduced stack use.

Dunno how performance sensitive these uses really are
but it seems some might be for slow cpu wireless APs in
both the rx and tx paths.