netdev - Re: [PATCH] skbuff: make skb_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170615.121806.1737755943471705142.davem@davemloft.net>
Date:   Thu, 15 Jun 2017 12:18:06 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     johannes@...solutions.net
Cc:     netdev@...r.kernel.org, johannes.berg@...el.com
Subject: Re: [PATCH] skbuff: make skb_put_zero() return void

From: Johannes Berg <johannes@...solutions.net>
Date: Wed, 14 Jun 2017 22:17:20 +0200

> From: Johannes Berg <johannes.berg@...el.com>
> 
> It's nicer to return void, since then there's no need to
> cast to any structures. Currently none of the users have
> a cast, but a number of future conversions do.
> 
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Applied.

Although a bit disruptive, it might be nice to convert all of the
other "char *" related data pointers in skbuff based interfaces.

No, I'm not asking you specifically to work on this, relax :)