netdev - RE: [PATCH net-next] qed: Fix an off by one bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR0701MB2005D7EC2C3C89C305AAF0508DC30@BY2PR0701MB2005.namprd07.prod.outlook.com>
Date:   Wed, 14 Jun 2017 09:21:32 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH net-next] qed: Fix an off by one bug

> The p_l2_info->pp_qid_usage[] array has "p_l2_info->queues" elements so
> the > here should be a >= or we write beyond the end of the array.
> 
> Fixes: bbe3f233ec5e ("qed: Assign a unique per-queue index to queue-cid")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

While it's a theoretical fix [as check is defensive; the queue-id was supposed
to be validated before reaching this part], it's still the right. Thanks Dan.

Acked-by: Yuval Mintz <Yuval.Mintz@...ium.com>