netdev - Re: [PATCH 2/2] ip6_tunnel: fix ip6 tunnel lookup in collect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <AA106C31-8154-43E9-AEA7-7D2D7E451C67@cmss.chinamobile.com>
Date:   Fri, 16 Jun 2017 00:36:44 +0800
From:   严海双 <yanhaishuang@...s.chinamobile.com>
To:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Alexei Starovoitov <ast@...com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        linux-kernel@...r.kernel.or
Subject: Re: [PATCH 2/2] ip6_tunnel: fix ip6 tunnel lookup in collect_md mode



> On 16 Jun 2017, at 12:26 AM, Haishuang Yan <yanhaishuang@...s.chinamobile.com> wrote:
> 
> In collect_md mode, if the tun dev is down, it still can call
> __ip6_tnl_rcv to receive on packets, and the rx statistics increase
> improperly.
> 
> Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels")
> Cc: Alexei Starovoitov <ast@...com>
> Signed-off-by: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
> ---
> net/ipv6/ip6_tunnel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
> index 6400726..25961c7 100644
> --- a/net/ipv6/ip6_tunnel.c
> +++ b/net/ipv6/ip6_tunnel.c
> @@ -171,7 +171,7 @@ static struct net_device_stats *ip6_get_stats(struct net_device *dev)
> 	}
> 
> 	t = rcu_dereference(ip6n->collect_md_tun);
> -	if (t)
> +	if (t && (t->dev->flags & IFF_UP))
> 		return t;
> 
> 	t = rcu_dereference(ip6n->tnls_wc[0]);
> -- 
> 1.8.3.1
> 
> 
Please skip the patches, I wrote a wrong email address '_'!