netdev - Re: [PATCH net-next 02/13] sock: skb_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201706190955.o6jV11AS%fengguang.wu@intel.com>
Date:   Mon, 19 Jun 2017 09:23:24 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, davem@...emloft.net,
        linux-api@...r.kernel.org, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next 02/13] sock: skb_copy_ubufs support for compound
 pages

Hi Willem,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Willem-de-Bruijn/sock-allocate-skbs-from-optmem/20170619-072924
config: i386-randconfig-a0-06162344 (attached as .config)
compiler: gcc-5 (Debian 5.4.1-2) 5.4.1 20160904
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the linux-review/Willem-de-Bruijn/sock-allocate-skbs-from-optmem/20170619-072924 HEAD 967736700e28113ea867e0f2358aca7dcced7407 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   net//core/skbuff.c: In function 'skb_copy_ubufs':
>> net//core/skbuff.c:1016:2: error: 'uarg' undeclared (first use in this function)
     uarg->callback(uarg, false);
     ^
   net//core/skbuff.c:1016:2: note: each undeclared identifier is reported only once for each function it appears in

vim +/uarg +1016 net//core/skbuff.c

396206af Willem de Bruijn   2017-06-18  1000  				d_off = 0;
396206af Willem de Bruijn   2017-06-18  1001  				page = (struct page *)page_private(page);
396206af Willem de Bruijn   2017-06-18  1002  			}
396206af Willem de Bruijn   2017-06-18  1003  			copy = min_t(u32, PAGE_SIZE - d_off, f_size);
396206af Willem de Bruijn   2017-06-18  1004  			memcpy(page_address(page) + d_off, vaddr + f_off, copy);
396206af Willem de Bruijn   2017-06-18  1005  			f_size -= copy;
396206af Willem de Bruijn   2017-06-18  1006  			d_off += copy;
396206af Willem de Bruijn   2017-06-18  1007  			f_off += copy;
396206af Willem de Bruijn   2017-06-18  1008  		}
396206af Willem de Bruijn   2017-06-18  1009  		kunmap_atomic(vaddr);
396206af Willem de Bruijn   2017-06-18  1010  	}
396206af Willem de Bruijn   2017-06-18  1011  
a6686f2f Shirley Ma         2011-07-06  1012  	/* skb frags release userspace buffers */
02756ed4 Krishna Kumar      2012-07-17  1013  	for (i = 0; i < num_frags; i++)
a8605c60 Ian Campbell       2011-10-19  1014  		skb_frag_unref(skb, i);
a6686f2f Shirley Ma         2011-07-06  1015  
e19d6763 Michael S. Tsirkin 2012-11-01 @1016  	uarg->callback(uarg, false);
a6686f2f Shirley Ma         2011-07-06  1017  
a6686f2f Shirley Ma         2011-07-06  1018  	/* skb frags point to kernel buffers */
396206af Willem de Bruijn   2017-06-18  1019  	for (i = 0; i < new_frags - 1; i++) {
396206af Willem de Bruijn   2017-06-18  1020  		__skb_fill_page_desc(skb, i, head, 0, PAGE_SIZE);
40dadff2 Sunghan Suh        2013-07-12  1021  		head = (struct page *)page_private(head);
a6686f2f Shirley Ma         2011-07-06  1022  	}
396206af Willem de Bruijn   2017-06-18  1023  	__skb_fill_page_desc(skb, new_frags - 1, head, 0, d_off);
396206af Willem de Bruijn   2017-06-18  1024  	skb_shinfo(skb)->nr_frags = new_frags;

:::::: The code at line 1016 was first introduced by commit
:::::: e19d6763cc300fcb706bd291b24ac06be71e1ce6 skb: report completion status for zero copy skbs

:::::: TO: Michael S. Tsirkin <mst@...hat.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28219 bytes)