netdev - Re: [PATCH net-next 06/12] nfp: add stats and xmit helpers for representors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201706210132.VUFkNyd8%fengguang.wu@intel.com>
Date:   Wed, 21 Jun 2017 01:15:05 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Simon Horman <simon.horman@...ronome.com>
Cc:     kbuild-all@...org, David Miller <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        netdev@...r.kernel.org, oss-drivers@...ronome.com,
        Simon Horman <simon.horman@...ronome.com>
Subject: Re: [PATCH net-next 06/12] nfp: add stats and xmit helpers for
 representors

Hi Simon,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Simon-Horman/nfp-add-flower-app-with-representors/20170620-233831
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/net//ethernet/netronome/nfp/nfp_net_repr.c: In function 'nfp_repr_phy_port_get_stats64':
>> drivers/net//ethernet/netronome/nfp/nfp_net_repr.c:88:22: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
     stats->tx_packets = readq(mem + NFP_MAC_STATS_RX_FRAMES_RECEIVED_OK);
                         ^~~~~
   cc1: some warnings being treated as errors

vim +/readq +88 drivers/net//ethernet/netronome/nfp/nfp_net_repr.c

    72		stats->rx_packets++;
    73		stats->rx_bytes += len;
    74		u64_stats_update_end(&stats->syncp);
    75	}
    76	
    77	void
    78	nfp_repr_phy_port_get_stats64(const struct nfp_app *app, u8 phy_port,
    79				      struct rtnl_link_stats64 *stats)
    80	{
    81		u8 __iomem *mem;
    82	
    83		mem = app->pf->mac_stats_mem + phy_port * NFP_MAC_STATS_SIZE;
    84	
    85		/* TX and RX stats are flipped as we are returning the stats as seen
    86		 * at the switch port corresponding to the phys port.
    87		 */
  > 88		stats->tx_packets = readq(mem + NFP_MAC_STATS_RX_FRAMES_RECEIVED_OK);
    89		stats->tx_bytes = readq(mem + NFP_MAC_STATS_RX_IN_OCTETS);
    90		stats->tx_dropped = readq(mem + NFP_MAC_STATS_RX_IN_ERRORS);
    91	
    92		stats->rx_packets = readq(mem + NFP_MAC_STATS_TX_FRAMES_TRANSMITTED_OK);
    93		stats->rx_bytes = readq(mem + NFP_MAC_STATS_TX_OUT_OCTETS);
    94		stats->rx_dropped = readq(mem + NFP_MAC_STATS_TX_OUT_ERRORS);
    95	}
    96	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (62499 bytes)