netdev - RE: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device definitions to UAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <748B799B6A00724488C603FD7E5E7EB976FA5C5C@FMSMSX114.amr.corp.intel.com>
Date:   Wed, 21 Jun 2017 16:18:54 +0000
From:   "Tung, Chien Tin" <chien.tin.tung@...el.com>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Leon Romanovsky <leon@...nel.org>
CC:     Doug Ledford <dledford@...hat.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Steve Wise <swise@...ngridcomputing.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Ariel Almog <ariela@...lanox.com>,
        Linux Netdev <netdev@...r.kernel.org>,
        Leon Romanovsky <leonro@...lanox.com>
Subject: RE: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device
 definitions to UAPI

> From: Jason Gunthorpe [mailto:jgunthorpe@...idianresearch.com]
> Sent: Wednesday, June 21, 2017 11:12 AM
> To: Leon Romanovsky <leon@...nel.org>
> Cc: Doug Ledford <dledford@...hat.com>; linux-rdma@...r.kernel.org; Tung,
> Chien Tin <chien.tin.tung@...el.com>; Steve Wise
> <swise@...ngridcomputing.com>; Stephen Hemminger
> <stephen@...workplumber.org>; Jiri Pirko <jiri@...lanox.com>; Ariel Almog
> <ariela@...lanox.com>; Linux Netdev <netdev@...r.kernel.org>; Leon
> Romanovsky <leonro@...lanox.com>
> Subject: Re: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device
> definitions to UAPI
> 
> On Wed, Jun 21, 2017 at 09:05:22AM +0300, Leon Romanovsky wrote:
> >  	RDMA_NL_IWCM,
> >  	RDMA_NL_RSVD,
> >  	RDMA_NL_LS,	/* RDMA Local Services */
> > +	/*
> > +	 * RDMA_NL_I40IW not in use and it was added here by mistake,
> > +	 * but we need to keep it anyway, because it is UAPI and for
> > +	 * unknown reasons, someone in the field decided to replace "5"
> > +	 * with this define.
> > +	 */
> >  	RDMA_NL_I40IW,
> 
> Since this doesn't do anything, never did anything, I think you should just
> delete it. Anything in userspace that refers to this name is unconditionally
> broken and a compile failure is the better choice.
> 
> Jason

I agree.  Please delete RDMA_NL_I40IW.

Chien