netdev - Re: [PATCH net-next] ibmvnic: Correct return code checking for ibmvnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170621.153936.1668683376357645391.davem@davemloft.net>
Date:   Wed, 21 Jun 2017 15:39:36 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     nfont@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, jallen@...ux.vnet.ibm.com,
        tlfalcon@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Correct return code checking for
 ibmvnic_init during probe

From: Nathan Fontenot <nfont@...ux.vnet.ibm.com>
Date: Tue, 20 Jun 2017 17:21:54 -0400

> Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)

I'm incredibly curious where you got the idea to put the Fixes: tag
at the beginning of the commit message.

Have you seen anyone else submitting patches on netdev do this?

It helps to operate by example, and look at how other people do
things.

The correct location for the Fixes: tag is at the beginning of the
singoffs and acks at the end of the commit message.

There shall be no empty lines between the Fixes: tag and those
signoffs and acks.

Thank you.