netdev - Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170621025903.GA1261@felix-thinkpad.cavium.com>
Date:   Tue, 20 Jun 2017 19:59:03 -0700
From:   Felix Manlunas <felix.manlunas@...ium.com>
To:     David Miller <davem@...emloft.net>
Cc:     Derek.Chickles@...ium.com, dvlasenk@...hat.com,
        netdev@...r.kernel.org, Prasad.Kanneganti@...ium.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in
 .data

From: David Miller <davem@...emloft.net>
Date: Tue, 20 Jun 2017 21:17:13 -0400

> From: Felix Manlunas <felix.manlunas@...ium.com>
> Date: Tue, 20 Jun 2017 13:51:25 -0700
> 
> > From: Derek Chickles <Derek.Chickles@...ium.com>
> > Date: Tue, 20 Jun 2017 13:15:34 -0700
> > 
> >> > From: David Miller [mailto:davem@...emloft.net]
> >> > Sent: Tuesday, June 20, 2017 12:22 PM
> >> > 
> >> > From: Denys Vlasenko <dvlasenk@...hat.com>
> >> > Date: Mon, 19 Jun 2017 21:50:52 +0200
> >> > 
> >> > > Only compile-tested - I don't have the hardware.
> >> > >
> >> > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt
> >> > > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned
> >> > > anyway.
> >> > >
> >> > > Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> >> > 
> >> > Looks good to me but I'll let one of the liquidio guys review this first
> >> > before I apply it.
> >> 
> >> Felix is going to try this out this week to confirm. Let's wait for his ack.
> > 
> > This patch works.  I tested it with a LiquidIO II adapter.
> > 
> > ACK
> 
> Please ACK patches in the standard way which is in the form of:
> 
> Acked-by: David S. Miller <davem@...emloft.net>
> 
> This tag is recognized by tools and in particular the patchwork
> site where networking patches are maintained, automatically
> including your ACK into the patch I apply.

Acked-by: Felix Manlunas <felix.manlunas@...ium.com>