netdev - Re: [PATCH net] udp: ipv6: reset daddr and dport in sk if connect() fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170622.135408.293309819386939085.davem@davemloft.net>
Date:   Thu, 22 Jun 2017 13:54:08 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     weiwan@...gle.com
Cc:     tracywwnj@...il.com, netdev@...r.kernel.org,
        subashab@...eaurora.org, maze@...gle.com
Subject: Re: [PATCH net] udp: ipv6: reset daddr and dport in sk if
 connect() fails

From: Wei Wang <weiwan@...gle.com>
Date: Thu, 22 Jun 2017 10:49:24 -0700

> On Thu, Jun 22, 2017 at 10:25 AM, David Miller <davem@...emloft.net> wrote:
>> From: Wei Wang <tracywwnj@...il.com>
>> Date: Wed, 21 Jun 2017 14:36:31 -0700
>>
>>> +             memset(&sk->sk_v6_daddr, 0 sizeof(sk->sk_v6_daddr);
>>
>> Tell me how that compiles.
> 
> Really sorry about that. I ported over the change manually from
> another branch and made the stupid mistake...
> Will send out v2 shortly.

Misporting the change isn't stupid.

Not build and functionally testing your change is.