netdev - Re: [PATCH net] udp: ipv6: reset daddr and dport in sk if connect() fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEA6p_DxFKuiW4+tGzFNnB7qhcBiNEAk0LTLqEV=OppHYKaeHw@mail.gmail.com>
Date:   Thu, 22 Jun 2017 11:00:42 -0700
From:   Wei Wang <weiwan@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     王蔚 <tracywwnj@...il.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        subashab@...eaurora.org,
        Maciej Żenczykowski <maze@...gle.com>
Subject: Re: [PATCH net] udp: ipv6: reset daddr and dport in sk if connect() fails

On Thu, Jun 22, 2017 at 10:54 AM, David Miller <davem@...emloft.net> wrote:
> From: Wei Wang <weiwan@...gle.com>
> Date: Thu, 22 Jun 2017 10:49:24 -0700
>
>> On Thu, Jun 22, 2017 at 10:25 AM, David Miller <davem@...emloft.net> wrote:
>>> From: Wei Wang <tracywwnj@...il.com>
>>> Date: Wed, 21 Jun 2017 14:36:31 -0700
>>>
>>>> +             memset(&sk->sk_v6_daddr, 0 sizeof(sk->sk_v6_daddr);
>>>
>>> Tell me how that compiles.
>>
>> Really sorry about that. I ported over the change manually from
>> another branch and made the stupid mistake...
>> Will send out v2 shortly.
>
> Misporting the change isn't stupid.
>
> Not build and functionally testing your change is.

Yes. Agree...
I did the testing on the other branch but did not do it again after
porting the change over.
Will definitely remember to do it next time. Really sorry about it...