netdev - Re: [PATCH v2 net] udpv6: reset daddr and dport in sk if connect() fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHo-OozNvQc0mboSnvQL6NjSJHTEu4ca2SYCPrtGL9+5djh+fw@mail.gmail.com>
Date:   Thu, 22 Jun 2017 12:21:11 -0700
From:   Maciej Żenczykowski <zenczykowski@...il.com>
To:     Wei Wang <tracywwnj@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Linux NetDev <netdev@...r.kernel.org>,
        Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        Wei Wang <weiwan@...gle.com>
Subject: Re: [PATCH v2 net] udpv6: reset daddr and dport in sk if connect() fails

So this is clearly an improvement over the current state of things.

However, I think there is still a very slight race condition in the
error case, since I imagine udp early demux might find the socket
while ip6_datagram_dst_update() is running.

It's possible that inet_dport assignment could simply be postponed
until after the ip6_datagram_dst_update() call.

Another possibility would be to make the early demux code only capable
of finding TCP_ESTABLISHED sockets.

That said, I'm not sure what the right call would be.