netdev - Re: [PATCH v2 net] udpv6: reset daddr and dport in sk if connect() fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170623.140343.1430137406292396677.davem@davemloft.net>
Date:   Fri, 23 Jun 2017 14:03:43 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tracywwnj@...il.com
Cc:     netdev@...r.kernel.org, maze@...gle.com, subashab@...eaurora.org,
        weiwan@...gle.com
Subject: Re: [PATCH v2 net] udpv6: reset daddr and dport in sk if connect()
 fails

From: Wei Wang <tracywwnj@...il.com>
Date: Thu, 22 Jun 2017 12:03:41 -0700

> From: Wei Wang <weiwan@...gle.com>
> 
> In __ip6_datagram_connect(), reset sk->sk_v6_daddr and inet->dport if
> error occurs so that udp_v6_early_demux() won't consider this socket
> as a valid candidate for early demux.
> 
> v2: fix compilation error
> 
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Acked-by: Maciej Żenczykowski <maze@...gle.com>

Please also add a state test against TCP_ESTABLISHED in UDP v6 early
demux to close this race completely.

Thanks.