netdev - Re: [Intel-wired-lan] [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

Open Source and information security mailing list archives

Message-ID: <92573970-6eb7-9f4f-a512-4a467d4f6caf@intel.com>
Date:   Thu, 22 Jun 2017 09:54:59 +0300
From:   "Neftin, Sasha" <sasha.neftin@...el.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Ethan Zhao <ethan.kernel@...il.com>
Cc:     netdev <netdev@...r.kernel.org>, intel-wired-lan@...ts.osuosl.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH] net: intel: e1000e: add check on
 e1e_wphy() return value

On 21/06/2017 22:52, Gustavo A. R. Silva wrote:
> Hi Ethan,
>
> Quoting Ethan Zhao <ethan.kernel@...il.com>:
>
>> Gustavo,
>>
>>    The return value of ret_val seems used to check if the access to 
>> PHY/NVM
>> got its semaphore,  generally speaking, it is needed for every PHY
>> access of this driver.
>>
>> Reviewed-by: Ethan Zhao <ethan.zhao@...cle.com>
>>
>
> Thank you very much for the clarification.
>
>> On Wed, Jun 21, 2017 at 5:22 AM, Gustavo A. R. Silva
>> <garsilva@...eddedor.com> wrote:
>>> Check return value from call to e1e_wphy(). This value is being
>>> checked during previous calls to function e1e_wphy() and it seems
>>> a check was missing here.
>>>
>>> Addresses-Coverity-ID: 1226905
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>>> ---
>>>  drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c 
>>> b/drivers/net/ethernet/intel/e1000e/ich8lan.c
>>> index 68ea8b4..d6d4ed7 100644
>>> --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
>>> +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
>>> @@ -2437,6 +2437,8 @@ static s32 
>>> e1000_hv_phy_workarounds_ich8lan(struct e1000_hw *hw)
>>>                 if (hw->phy.revision < 2) {
>>>                         e1000e_phy_sw_reset(hw);
>>>                         ret_val = e1e_wphy(hw, MII_BMCR, 0x3140);
>>> +                       if (ret_val)
>>> +                               return ret_val;
>>>                 }
>>>         }
>>>
>>> -- 
>>> 2.5.0
>>>
>
> -- 
> Gustavo A. R. Silva
>
>
>
>
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

We will accept this patch.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives