netdev - Re: [PATCH v3 net] net: ipv6: reset daddr and dport in sk if connect() fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170625.114651.1973887687669104262.davem@davemloft.net>
Date:   Sun, 25 Jun 2017 11:46:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tracywwnj@...il.com
Cc:     netdev@...r.kernel.org, maze@...gle.com, subashab@...eaurora.org,
        weiwan@...gle.com
Subject: Re: [PATCH v3 net] net: ipv6: reset daddr and dport in sk if
 connect() fails

From: Wei Wang <tracywwnj@...il.com>
Date: Fri, 23 Jun 2017 15:25:37 -0700

> From: Wei Wang <weiwan@...gle.com>
> 
> In __ip6_datagram_connect(), reset sk->sk_v6_daddr and inet->dport if
> error occurs.
> In udp_v6_early_demux(), check for sk_state to make sure it is in
> TCP_ESTABLISHED state.
> Together, it makes sure unconnected UDP socket won't be considered as a
> valid candidate for early demux.
> 
> Fixes: 5425077d73e0 ("net: ipv6: Add early demux handler for UDP unicast")
> 
> v3: add TCP_ESTABLISHED state check in udp_v6_early_demux()
> v2: fix compilation error
> 
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Acked-by: Maciej Żenczykowski <maze@...gle.com>

Please don't format the tag area like this, if you want to put a change
log put it first.

Then put all of the tags (Fixes:, Signed-off-by:, Acked-by:, etc.)
together with no empty line separators, at the end.

I fixed it up this time.

Applied and queued up for -stable, thanks.