netdev - Re: [PATCH v3 net] net: ipv6: reset daddr and dport in sk if connect() fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEA6p_AScKpmjBCKK4Eg=UNtAde2oti9ymXGcnkCW4fvmC9KKg@mail.gmail.com>
Date:   Sun, 25 Jun 2017 13:47:53 -0700
From:   Wei Wang <weiwan@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     王蔚 <tracywwnj@...il.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Maciej Żenczykowski <maze@...gle.com>,
        Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Subject: Re: [PATCH v3 net] net: ipv6: reset daddr and dport in sk if
 connect() fails

On Sun, Jun 25, 2017 at 8:46 AM, David Miller <davem@...emloft.net> wrote:
> From: Wei Wang <tracywwnj@...il.com>
> Date: Fri, 23 Jun 2017 15:25:37 -0700
>
>> From: Wei Wang <weiwan@...gle.com>
>>
>> In __ip6_datagram_connect(), reset sk->sk_v6_daddr and inet->dport if
>> error occurs.
>> In udp_v6_early_demux(), check for sk_state to make sure it is in
>> TCP_ESTABLISHED state.
>> Together, it makes sure unconnected UDP socket won't be considered as a
>> valid candidate for early demux.
>>
>> Fixes: 5425077d73e0 ("net: ipv6: Add early demux handler for UDP unicast")
>>
>> v3: add TCP_ESTABLISHED state check in udp_v6_early_demux()
>> v2: fix compilation error
>>
>> Signed-off-by: Wei Wang <weiwan@...gle.com>
>> Acked-by: Maciej Żenczykowski <maze@...gle.com>
>
> Please don't format the tag area like this, if you want to put a change
> log put it first.
>
> Then put all of the tags (Fixes:, Signed-off-by:, Acked-by:, etc.)
> together with no empty line separators, at the end.
>
> I fixed it up this time.
>
> Applied and queued up for -stable, thanks.

Got it. Will note it down.
Thanks for taking care of it.

Wei