netdev - Re: CAN-FD Transceiver Limitations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170629171900.GA17008@lunn.ch>
Date:   Thu, 29 Jun 2017 19:19:00 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Franklin S Cooper Jr <fcooper@...com>
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        wg@...ndegger.com, mkl@...gutronix.de, devicetree@...r.kernel.org
Subject: Re: CAN-FD Transceiver Limitations

> Also I agree that attempting to make this optional property/subnode
> generic to all of CAN would be preferable. Another not sure if its
> feasible yet without standardization being first forced across all CAN
> drivers.

It should be. All you need to do is add an
of_get_can_maxspeed(struct device_node *np)
for drivers to call.

If it finds the property, return its value, otherwise return the
standardised 1Mbps.

And you probably want to do the verify in can_changelink(), by adding
the max speed into the can_priv structure somewhere.

    Andrew