netdev - Re: [PATCH net-next v2 9/9] nfp: add control message passing capabilities to flower offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170629173527.GA18062@vergenet.net>
Date:   Thu, 29 Jun 2017 19:35:29 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Or Gerlitz <gerlitz.or@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        oss-drivers@...ronome.com,
        Pieter Jansen van Vuuren 
        <pieter.jansenvanvuuren@...ronome.com>
Subject: Re: [PATCH net-next v2 9/9] nfp: add control message passing
 capabilities to flower offloads

On Thu, Jun 29, 2017 at 06:59:22PM +0300, Or Gerlitz wrote:
> On Thu, Jun 29, 2017 at 6:30 PM, Simon Horman
> <simon.horman@...ronome.com> wrote:
> > On Thu, Jun 29, 2017 at 06:21:53PM +0300, Or Gerlitz wrote:
> >> On Wed, Jun 28, 2017 at 11:30 PM, Simon Horman
> >> <simon.horman@...ronome.com> wrote:
> >> > +++ b/drivers/net/ethernet/netronome/nfp/flower/cmsg.h
> >> > @@ -245,7 +245,11 @@ struct nfp_flower_cmsg_hdr {
> >> >
> >> >  /* Types defined for port related control messages  */
> >> >  enum nfp_flower_cmsg_type_port {
> >> > +       NFP_FLOWER_CMSG_TYPE_FLOW_ADD =         0,
> >> > +       NFP_FLOWER_CMSG_TYPE_FLOW_MOD =         1,
> >>
> >> AFAIU flower offload will always use delete and add and not modify,
> >> if you think otherwise, would love to hear that. Didn't see you are using
> >> the MOD define in the code anywhere.
> >
> > The firmware API has a mod operation but you are correct that
> > we are not implementing that operation in this patch-set.
> 
> that wasn't my comment. I said that AFAIU flower will never ask you to
> modify, they
> will ask to delete and later add, so I would be happy to know if you
> see it differently.

Yes, I agree.

Sorry for not answering your question properly the first time.