netdev - Re: [PATCH net-next v2 5/9] nfp: extend flower matching capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2017 17:31:22 +0300
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Simon Horman <simon.horman@...ronome.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        oss-drivers@...ronome.com,
        Pieter Jansen van Vuuren 
        <pieter.jansenvanvuuren@...ronome.com>
Subject: Re: [PATCH net-next v2 5/9] nfp: extend flower matching capabilities

On Wed, Jun 28, 2017 at 11:29 PM, Simon Horman
<simon.horman@...ronome.com> wrote:
> +       /* Populate IPv4 frame. */
> +       frame->reserved = 0;
> +       frame->ipv4_src = flow_ipv4->src;
> +       frame->ipv4_dst = flow_ipv4->dst;
> +       frame->proto = flow_basic->ip_proto;
> +       /* Wildcard TOS/TTL as TC can't match them yet. */

FWIW this is wrong... matching on both was added recently

> +       frame->tos = 0;
> +       frame->ttl = 0;

note that the same flow dissector matching is used for ipv4 ttl/tos
and ipv6 hoplimit/traffic class