netdev - Re: [PATCH net-next v2 3/9] nfp: provide infrastructure for offloading flower based TC filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170629143147.GA4149@vergenet.net>
Date:   Thu, 29 Jun 2017 16:31:49 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Or Gerlitz <gerlitz.or@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        oss-drivers@...ronome.com,
        Pieter Jansen van Vuuren 
        <pieter.jansenvanvuuren@...ronome.com>
Subject: Re: [PATCH net-next v2 3/9] nfp: provide infrastructure for
 offloading flower based TC filters

On Thu, Jun 29, 2017 at 04:56:44PM +0300, Or Gerlitz wrote:
> On Wed, Jun 28, 2017 at 11:29 PM, Simon Horman
> <simon.horman@...ronome.com> wrote:
> 
> > +++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c
> 
> > + * nfp_flower_del_offload() - Removes a flow from hardware.
> > + * @app:       Pointer to the APP handle
> > + * @netdev:    netdev structure.
> > + * @flow:       TC flower classifier offload structure
> 
> The copy from patchworks has some damage on this line
> 
>  * @flow: ֲ| ֲ| ֲ| ֲ| ֲ| ֲ| TC flower classifier offload structure
> 
> and the same line for get stats, take a look

Thanks, I will fix that whitespace damage.

> 
> > + * nfp_flower_get_stats() - Populates flow stats obatain from hardware.
> > + * @app:       Pointer to the APP handle
> > + * @flow:       TC flower classifier offload structure <-- here too