netdev - bug in "PCI: Support INTx masking on ConnectX-4 with firmware x.14.1100+"?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK1hOcP-+=8SMi8z6zxwqYYcJtSnGHv36Db6fj3Zenux0ViN4g@mail.gmail.com>
Date:   Mon, 10 Jul 2017 18:49:07 +0200
From:   Denys Vlasenko <vda.linux@...glemail.com>
To:     Noa Osherovich <noaos@...lanox.com>,
        netdev <netdev@...r.kernel.org>
Subject: bug in "PCI: Support INTx masking on ConnectX-4 with firmware x.14.1100+"?

+       /* Reading from resource space should be 32b aligned */
+       fw_maj_min = ioread32be(fw_ver);
+       fw_sub_min = ioread32be(fw_ver + 1);
+       fw_major = fw_maj_min & 0xffff;
+       fw_minor = fw_maj_min >> 16;
+       fw_subminor = fw_sub_min & 0xffff;

Maybe second read should be ioread32be(fw_ver + 4)?