netdev - Re: bug in "PCI: Support INTx masking on ConnectX-4 with firmware x.14.1100+"?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f3fce8a-61d4-8878-c351-b138ffec6e86@mellanox.com>
Date:   Wed, 12 Jul 2017 10:58:22 +0300
From:   Noa Osherovich <noaos@...lanox.com>
To:     Denys Vlasenko <vda.linux@...glemail.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: bug in "PCI: Support INTx masking on ConnectX-4 with firmware
 x.14.1100+"?

Hi,

On 7/10/2017 7:49 PM, Denys Vlasenko wrote:

> +       /* Reading from resource space should be 32b aligned */
> +       fw_maj_min = ioread32be(fw_ver);
> +       fw_sub_min = ioread32be(fw_ver + 1);
> +       fw_major = fw_maj_min & 0xffff;
> +       fw_minor = fw_maj_min >> 16;
> +       fw_subminor = fw_sub_min & 0xffff;
>
> Maybe second read should be ioread32be(fw_ver + 4)?
>
fw_ver is a pointer:

__be32 __iomem *fw_ver;

Increasing its value means incrementing it by the size of its contents
thus reading the next 32 bits.

Doesn't seem like a bug.

Thanks, Noa