netdev - Re: [PATCH V3] Set NTB format again after altsetting switch for Huawei devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170714.081519.1938487375638130917.davem@davemloft.net>
Date:   Fri, 14 Jul 2017 08:15:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mrkiko.rs@...il.com
Cc:     bjorn@...k.no, christian@...ton.org, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, oliver@...kum.org
Subject: Re: [PATCH V3] Set NTB format again after altsetting switch for
 Huawei devices

From: Enrico Mioso <mrkiko.rs@...il.com>
Date: Tue, 11 Jul 2017 17:21:52 +0200

> Some firmwares in Huawei E3372H devices have been observed to switch back
> to NTB 32-bit format after altsetting switch.
> This patch implements a driver flag to check for the device settings and
> set NTB format to 16-bit again if needed.
> The flag has been activated for devices controlled by the huawei_cdc_ncm.c
> driver.
> 
> V1->V2:
> - fixed broken error checks
> - some corrections to the commit message
> V2->V3:
> - variable name changes, to clarify what's happening
> - check (and possibly set) the NTB format later in the common bind code path
> 
> Signed-off-by: Enrico Mioso <mrkiko.rs@...il.com>
> Reported-and-tested-by: Christian Panton <christian@...ton.org>
> Reviewed-by: Bjørn Mork <bjorn@...k.no>

Applied, thanks.