netdev - Re: [Patch net] netpoll: shut up a kernel warning on refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170714.081740.1892120761671347344.davem@davemloft.net>
Date:   Fri, 14 Jul 2017 08:17:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, davej@...emonkey.org.uk,
        elena.reshetova@...el.com
Subject: Re: [Patch net] netpoll: shut up a kernel warning on refcount

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Wed, 12 Jul 2017 15:56:41 -0700

> When we convert atomic_t to refcount_t, a new kernel warning
> on "increment on 0" is introduced in the netpoll code,
> zap_completion_queue(). In fact for this special case, we know
> the refcount is 0 and we just have to set it to 1 to satisfy
> the following dev_kfree_skb_any(), so we can just use
> refcount_set(..., 1) instead.
> 
> Fixes: 633547973ffc ("net: convert sk_buff.users from atomic_t to refcount_t")
> Reported-by: Dave Jones <davej@...emonkey.org.uk>
> Cc: Reshetova, Elena <elena.reshetova@...el.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thanks Cong.