netdev - Re: [PATCH] ipv4: ip_do_fragment: fix headroom tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170715.143855.2063043330641361274.davem@davemloft.net>
Date:   Sat, 15 Jul 2017 14:38:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vvs@...tuozzo.com
Cc:     netdev@...r.kernel.org, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, fw@...len.de, dwmw2@...radead.org,
        devel@...nvz.org
Subject: Re: [PATCH] ipv4: ip_do_fragment: fix headroom tests

From: Vasily Averin <vvs@...tuozzo.com>
Date: Fri, 14 Jul 2017 12:04:16 +0300

> Some time ago David Woodhouse reported skb_under_panic
> when we try to push ethernet header to fragmented ipv6 skbs.
> It was fixed for ipv6 by Florian Westphal in
> commit 1d325d217c7f ("ipv6: ip6_fragment: fix headroom tests and skb leak")
> 
> However similar problem still exist in ipv4.
> 
> It does not trigger skb_under_panic due paranoid check
> in ip_finish_output2, however according to Alexey Kuznetsov
> current state is abnormal and ip_fragment should be fixed too.
> 
> Signed-off-by: Vasily Averin <vvs@...tuozzo.com>

Applied, thank you.