netdev - Re: [PATCH V3 net] openvswitch: Fix for force/commit action failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 15 Jul 2017 14:40:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gvrose8192@...il.com
Cc:     netdev@...r.kernel.org, pshelar@...ira.com, dev@...nvswitch.org,
        joe@....org
Subject: Re: [PATCH V3 net] openvswitch: Fix for force/commit action
 failures

From: Greg Rose <gvrose8192@...il.com>
Date: Fri, 14 Jul 2017 12:42:49 -0700

> When there is an established connection in direction A->B, it is
> possible to receive a packet on port B which then executes
> ct(commit,force) without first performing ct() - ie, a lookup.
> In this case, we would expect that this packet can delete the existing
> entry so that we can commit a connection with direction B->A. However,
> currently we only perform a check in skb_nfct_cached() for whether
> OVS_CS_F_TRACKED is set and OVS_CS_F_INVALID is not set, ie that a
> lookup previously occurred. In the above scenario, a lookup has not
> occurred but we should still be able to statelessly look up the
> existing entry and potentially delete the entry if it is in the
> opposite direction.
> 
> This patch extends the check to also hint that if the action has the
> force flag set, then we will lookup the existing entry so that the
> force check at the end of skb_nfct_cached has the ability to delete
> the connection.
> 
> Fixes: dd41d330b03 ("openvswitch: Add force commit.")
> CC: Pravin Shelar <pshelar@...ira.com>
> CC: dev@...nvswitch.org
> Signed-off-by: Joe Stringer <joe@....org>
> Signed-off-by: Greg Rose <gvrose8192@...il.com>

Applied, thanks.