netdev - Re: [PATCH 1/2] ftgmac100: Increase reset timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CACPK8XdUJK8x7Zc1nLceSpM-Bt0zW13F-OGTJKrNgGGxFtY76w@mail.gmail.com>
Date:   Mon, 24 Jul 2017 22:39:52 +0930
From:   Joel Stanley <joel@....id.au>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     netdev@...r.kernel.org, Joel Stanley <joel.stanley@....ibm.com>
Subject: Re: [PATCH 1/2] ftgmac100: Increase reset timeout

On Mon, Jul 24, 2017 at 4:29 PM, Benjamin Herrenschmidt
<benh@...nel.crashing.org> wrote:
> We had reports of 50us not being sufficient to reset the MAC,
> thus hitting the "Hardware reset failed" error bringing the
> interface up on some AST2400 based machines.
>
> This bumps the timeout to 200us.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>

I gave this a spin on the problematic hardware, as well as a few other
machines. Looks good, thanks Ben.

Tested-by: Joel Stanley <joel@....id.au>

Cheers,

Joel


> ---
>  drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index b166666128d3..2b17f7023d91 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -125,7 +125,7 @@ static int ftgmac100_reset_mac(struct ftgmac100 *priv, u32 maccr)
>         iowrite32(maccr, priv->base + FTGMAC100_OFFSET_MACCR);
>         iowrite32(maccr | FTGMAC100_MACCR_SW_RST,
>                   priv->base + FTGMAC100_OFFSET_MACCR);
> -       for (i = 0; i < 50; i++) {
> +       for (i = 0; i < 200; i++) {
>                 unsigned int maccr;
>
>                 maccr = ioread32(priv->base + FTGMAC100_OFFSET_MACCR);