netdev - Re: [PATCH 2/2] ftgmac100: Make the MDIO bus a child of the ethernet device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8XcHYHB128nesCLNzDkhNyuFoRgizi=WAqwr0PWcX_bOMQ@mail.gmail.com>
Date:   Mon, 24 Jul 2017 22:43:43 +0930
From:   Joel Stanley <joel@....id.au>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     netdev@...r.kernel.org, Joel Stanley <joel.stanley@....ibm.com>
Subject: Re: [PATCH 2/2] ftgmac100: Make the MDIO bus a child of the ethernet device

On Mon, Jul 24, 2017 at 4:29 PM, Benjamin Herrenschmidt
<benh@...nel.crashing.org> wrote:
> Populate mii_bus->parent with our own platform device before
> registering, which makes it easier to locate the MDIO bus
> in sysfs when trying to diagnose problems.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>

Acked-by: Joel Stanley <joel@....id.au>

> ---
>  drivers/net/ethernet/faraday/ftgmac100.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index 2b17f7023d91..fce0aa4f78b7 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -1682,6 +1682,7 @@ static int ftgmac100_setup_mdio(struct net_device *netdev)
>         priv->mii_bus->name = "ftgmac100_mdio";
>         snprintf(priv->mii_bus->id, MII_BUS_ID_SIZE, "%s-%d",
>                  pdev->name, pdev->id);
> +       priv->mii_bus->parent = priv->dev;
>         priv->mii_bus->priv = priv->netdev;
>         priv->mii_bus->read = ftgmac100_mdiobus_read;
>         priv->mii_bus->write = ftgmac100_mdiobus_write;
>