netdev - Re: [PATCH v2 net-next 2/2] liquidio: cleanup: removed cryptic and misleading macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Jul 2017 21:20:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com,
        ricardo.farrington@...ium.com
Subject: Re: [PATCH v2 net-next 2/2] liquidio: cleanup: removed cryptic and
 misleading macro

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Mon, 24 Jul 2017 17:17:27 -0700

> From: Rick Farrington <ricardo.farrington@...ium.com>
> 
> Signed-off-by: Rick Farrington <ricardo.farrington@...ium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>
> ---
>  drivers/net/ethernet/cavium/liquidio/octeon_console.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_console.c b/drivers/net/ethernet/cavium/liquidio/octeon_console.c
> index 501ad95..0770183 100644
> --- a/drivers/net/ethernet/cavium/liquidio/octeon_console.c
> +++ b/drivers/net/ethernet/cavium/liquidio/octeon_console.c
> @@ -42,8 +42,6 @@ module_param(console_bitmask, int, 0644);
>  MODULE_PARM_DESC(console_bitmask,
>  		 "Bitmask indicating which consoles have debug output redirected to syslog.");
>  
> -#define CAST_ULL(v) ((u64)(v))
> -
>  #define BOOTLOADER_PCI_READ_BUFFER_DATA_ADDR    0x0006c008
>  #define BOOTLOADER_PCI_READ_BUFFER_LEN_ADDR     0x0006c004
>  #define BOOTLOADER_PCI_READ_BUFFER_OWNER_ADDR   0x0006c000
> @@ -233,7 +231,7 @@ static int __cvmx_bootmem_check_version(struct octeon_device *oct,
>  	    (exact_match && major_version != exact_match)) {
>  		dev_err(&oct->pci_dev->dev, "bootmem ver mismatch %d.%d addr:0x%llx\n",
>  			major_version, minor_version,
> -			CAST_ULL(oct->bootmem_desc_addr));
> +			(long long)(oct->bootmem_desc_addr));

Too many parenthesis.

When oct->bootmem_desc_addr was the argument to a macro/function, yes
the parenthesis were necessary.  But now they should be removed.