netdev - Re: [PATCH] ftgmac100: return error in ftgmac100_alloc_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170725.212203.942836822088934965.davem@davemloft.net>
Date:   Tue, 25 Jul 2017 21:22:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     joel@....id.au
Cc:     benh@...nel.crashing.org, netdev@...r.kernel.org
Subject: Re: [PATCH] ftgmac100: return error in ftgmac100_alloc_rx_buf

From: Joel Stanley <joel@....id.au>
Date: Tue, 25 Jul 2017 10:19:01 +0930

> The error paths set err, but it's not returned.
> 
> I wondered if we should fix all of the callers to check the returned
> value, but Ben explains why the code is this way:
> 
>> Most call sites ignore it on purpose. There's nothing we can do if
>> we fail to get a buffer at interrupt time, so we point the buffer to
>> the scratch page so the HW doesn't DMA into lalaland and lose the
>> packet.
>>
>> The one call site that tests and can fail is the one used when brining
>> the interface up. If we fail to allocate at that point, we fail the
>> ifup. But as you noticed, I do have a bug not returning the error.
> 
> Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Signed-off-by: Joel Stanley <joel@....id.au>

Applied, thanks.