netdev - Re: [PATCH iproute2] bridge: Assume master at FDB modification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170726090820.0252da7e@xeon-e3>
Date:   Wed, 26 Jul 2017 09:08:20 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Arkadi Sharshevsky <arkadis@...lanox.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        nikolay@...ulusnetworks.com, vivien.didelot@...oirfairelinux.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH iproute2] bridge: Assume master at FDB modification

On Wed, 26 Jul 2017 18:36:34 +0300
Arkadi Sharshevsky <arkadis@...lanox.com> wrote:

> According to the man page the master flag should be the default, yet, the
> current code assumes otherwise.
> 
> Signed-off-by: Arkadi Sharshevsky <arkadis@...lanox.com>

Agree that the documentation and code don't match.
But your change could break users with existing scripts by changing behavior.

It would be safer to change the man page not the code.