netdev - Re: [PATCH iproute2] bridge: Assume master at FDB modification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8516b28-bdab-9b6a-539a-d069d100b579@mellanox.com>
Date:   Wed, 26 Jul 2017 19:21:49 +0300
From:   Arkadi Sharshevsky <arkadis@...lanox.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        nikolay@...ulusnetworks.com, vivien.didelot@...oirfairelinux.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH iproute2] bridge: Assume master at FDB modification



On 07/26/2017 07:08 PM, Stephen Hemminger wrote:
> On Wed, 26 Jul 2017 18:36:34 +0300
> Arkadi Sharshevsky <arkadis@...lanox.com> wrote:
> 
>> According to the man page the master flag should be the default, yet, the
>> current code assumes otherwise.
>>
>> Signed-off-by: Arkadi Sharshevsky <arkadis@...lanox.com>
> 
> Agree that the documentation and code don't match.
> But your change could break users with existing scripts by changing behavior.
> 
> It would be safer to change the man page not the code.
> 

Can we maybe set master and self by default. It doesn't make
sense by default to not include the bridge, it will not cause
regression in this case.