netdev - Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKh23FmRBqgc7Yi0ANhkUMk=NZteRuT3UbK1DffzdjYWDX5fbg@mail.gmail.com>
Date:   Fri, 28 Jul 2017 11:40:30 -0700
From:   Iyappan Subramanian <isubramanian@....com>
To:     Tom Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Laura Abbott <labbott@...hat.com>,
        Keyur Chudgar <kchudgar@....com>,
        Quan Nguyen <qnguyen@....com>, netdev <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource
 for SGMII interfaces

On Fri, Jul 28, 2017 at 7:23 AM, Tom Bogendoerfer
<tsbogend@...ha.franken.de> wrote:
> On Thu, Jul 27, 2017 at 03:39:58PM -0700, Laura Abbott wrote:
>> I don't know the intricacies of the Mustang hardware but external
>> aborts have been a symptom of missing clocks on other hardware.
>
> you are right, it's a missing clock. For SGMII ports the driver
> doesn't really use the clock source other then doing the one
> devm_clk_get(), but this is enough to get the clock going.
>
> Below patch fixes the crash and brings back the second SGMII port
> (even without a clock source in device tree, I guess it uses clock
> from first port).  From a correctness standpoint there should probably
> be a clk_prepare_enable(), if port is SGMII.
>
> Could you test the patch ? If it works, I'll submit it.
>
> Thomas.
>
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> index 86058a9f3417..1d307f2def2d 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -1785,9 +1785,9 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata)
>
>         xgene_enet_gpiod_get(pdata);
>
> -       if (pdata->phy_mode != PHY_INTERFACE_MODE_SGMII) {
> -               pdata->clk = devm_clk_get(&pdev->dev, NULL);
> -               if (IS_ERR(pdata->clk)) {
> +       pdata->clk = devm_clk_get(&pdev->dev, NULL);
> +       if (IS_ERR(pdata->clk)) {
> +               if (pdata->phy_mode != PHY_INTERFACE_MODE_SGMII) {
>                         /* Abort if the clock is defined but couldn't be
>                          * retrived. Always abort if the clock is missing on
>                          * DT system as the driver can't cope with this case.
>
> --

Thanks for the patch.

Acked-by: Iyappan Subramanian <isubramanian@....com>

> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]