netdev - Re: [Patch net-next 1/2] net_sched: refactor notification code for RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b8c926f-8c28-b403-e380-c6ae521c9cc0@mojatatu.com>
Date:   Sun, 6 Aug 2017 07:42:13 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     jiri@...nulli.us
Subject: Re: [Patch net-next 1/2] net_sched: refactor notification code for
 RTM_DELTFILTER

On 17-08-05 12:31 AM, Cong Wang wrote:
> It is confusing to use 'unsigned long fh' as both a handle
> and a pointer, especially commit 9ee7837449b3
> ("net sched filters: fix notification of filter delete with proper handle").
> 
> This patch introduces tfilter_del_notify() so that we can
> pass it as a pointer as before, and we don't need to check
> RTM_DELTFILTER in tcf_fill_node() any more.
>
> This prepares for the next patch.
>


Looks good to me.
A small question below:


> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Cc: Jiri Pirko <jiri@...nulli.us>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>   net/sched/cls_api.c | 44 +++++++++++++++++++++++++++++++++++++++-----
>   1 file changed, 39 insertions(+), 5 deletions(-)
> 
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index e655221c654e..afd099727aea 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -104,6 +104,10 @@ static int tfilter_notify(struct net *net, struct sk_buff *oskb,
>   			  struct nlmsghdr *n, struct tcf_proto *tp,
>   			  unsigned long fh, int event, bool unicast);
>   
> +static int tfilter_del_notify(struct net *net, struct sk_buff *oskb,
> +			      struct nlmsghdr *n, struct tcf_proto *tp,
> +			      unsigned long fh, bool unicast, bool *last);
> +

Any reason not to move the functin up here and getting rid of this
forward declaration?

otherwise:
Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal