netdev - Re: [Patch net-next 2/2] net_sched: use void pointer for filter handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e03eb2b1-df7c-ca61-1950-ed7c129f0235@mojatatu.com>
Date:   Sun, 6 Aug 2017 07:46:06 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     jiri@...nulli.us
Subject: Re: [Patch net-next 2/2] net_sched: use void pointer for filter
 handle

On 17-08-05 12:31 AM, Cong Wang wrote:
> Now we use 'unsigned long fh' as a pointer in every place,
> it is safe to convert it to a void pointer now. This gets
> rid of many casts to pointer.
> 

I dont recall why unsigned long was used back then (by Alexey)
given C has always allowed void * assigned to other types
(and such a pattern is widely used in the kernel)

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal