netdev - Re: [Patch net-next 1/2] net_sched: refactor notification code for RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWZV=XE=NDCVWSP2CNaYT9dgJ422ppmcUKF84FcHtZMzQ@mail.gmail.com>
Date:   Mon, 7 Aug 2017 10:50:02 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [Patch net-next 1/2] net_sched: refactor notification code for RTM_DELTFILTER

On Sun, Aug 6, 2017 at 4:42 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
> On 17-08-05 12:31 AM, Cong Wang wrote:
>> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
>> index e655221c654e..afd099727aea 100644
>> --- a/net/sched/cls_api.c
>> +++ b/net/sched/cls_api.c
>> @@ -104,6 +104,10 @@ static int tfilter_notify(struct net *net, struct
>> sk_buff *oskb,
>>                           struct nlmsghdr *n, struct tcf_proto *tp,
>>                           unsigned long fh, int event, bool unicast);
>>   +static int tfilter_del_notify(struct net *net, struct sk_buff *oskb,
>> +                             struct nlmsghdr *n, struct tcf_proto *tp,
>> +                             unsigned long fh, bool unicast, bool *last);
>> +
>
>
> Any reason not to move the functin up here and getting rid of this
> forward declaration?

It calls tcf_fill_node() which is defined at line 643,
it is called at line 602. Moving it requires moves the
rest, this makes this patch unnecessarily bigger.
Why not make it a separate patch?