netdev - Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <984b4d3e-c9c4-545a-280b-0673227136a5@mellanox.com>
Date:   Sun, 6 Aug 2017 16:07:08 +0300
From:   Arkadi Sharshevsky <arkadis@...lanox.com>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, ivecera@...hat.com,
        f.fainelli@...il.com, andrew@...n.ch, Woojung.Huh@...rochip.com,
        stephen@...workplumber.org, mlxsw@...lanox.com
Subject: Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform
 switchdev cleanup



On 08/04/2017 06:29 PM, Vivien Didelot wrote:
> Hi Arkadi, Jiri,
> 
> Jiri Pirko <jiri@...nulli.us> writes:
> 
>>> It seems impossible currently to move the self to be the default, and
>>> this introduces regression which you don't approve, so it seems few
>>> options left:
>>>
>>> a) Leave two ways to add fdb, through the bridge (by using the master
>>>   flag) which is introduced in this patchset, and by using the self
>>>   which is the legacy way. In this way no regression will be introduced,
>>>   yet, it feels confusing a bit. The benefit is that we (DSA/mlxsw)
>>>   will be synced.
>>> b) Leave only the self (which means removing patch no 4,5).
>>
>> I belive that option a) is the correct way to go. Introduction of self
>> inclusion was a mistake from the very beginning. I think that we should
>> just move one and correct this mistake.
>>
>> Vivien, any arguments against a)?
> 
> I do agree with a). Arkadi, when moving switchdev implementations inside
> of DSA core, can I ask you to move the ones considered as the legacy way
> into legacy.c and ideally comment it? Configuration from userspace is
> still very confusing and this will remind us to get rid of it one day.
> 
> 
> Thanks,
> 
>         Vivien
> 

Yeah, no problem.

Thanks,
Arkadi